[EMAIL PROTECTED] wrote:
--- spamassassin/trunk/t/spf.t (original)
+++ spamassassin/trunk/t/spf.t Thu Dec 14 05:45:03 2006
@@ -454,7 +454,11 @@
);
sarun ("-t < data/nice/spf3-received-spf", \&patterns_run_cb);
-ok_all_patterns();
+if (!HAS_MAILSPF) {
+ skip_all_patterns("this test requires Mail::SPF module");
+} else {
+ ok_all_patterns();
+}
# test usage of Received-SPF headers added by internal relays
@@ -476,5 +480,10 @@
);
sarun ("-t < data/nice/spf3-received-spf", \&patterns_run_cb);
-ok_all_patterns();
+
+if (!HAS_MAILSPF) {
+ skip_all_patterns("this test requires Mail::SPF module");
+} else {
+ ok_all_patterns();
+}
This makes no sense. The tests are only supposed to pass if they don't
use one of the SPF modules to get the results. Even if they were
dependent on an SPF module, both modules should be providing the same
results for all the test messages. Also, the checking of Received-SPF
headers has nothing to do with the modules, so it should work even if
you don't have either of the modules installed.
In any case... can you reproduce the failures? I can't...
/usr/bin/perl -T -w ../spamassassin -C log/test_rules_copy
--siteconfigpath log/localrules.tmp -p log/tst.cf -t <
data/nice/spf3-received-spf
Checking helo_pass
ok 47
Checking pass
ok 48
/usr/bin/perl -T -w ../spamassassin -C log/test_rules_copy
--siteconfigpath log/localrules.tmp -p log/tst.cf -t <
data/nice/spf3-received-spf
Checking fail_ignore_header
ok 49
Checking helo_fail_ignore_header
ok 50
/usr/bin/perl -T -w ../spamassassin -C log/test_rules_copy
--siteconfigpath log/localrules.tmp -p log/tst.cf -t <
data/nice/spf3-received-spf
Checking helo_softfail_from_header
ok 51
Checking neutral_from_header
ok 52
/usr/bin/perl -T -w ../spamassassin -C log/test_rules_copy
--siteconfigpath log/localrules.tmp -p log/tst.cf -t <
data/nice/spf3-received-spf
Checking fail_from_header
ok 53
Checking helo_softfail_from_header
ok 54
[EMAIL PROTECTED] trunk]$ perl -e 'use Mail::SPF'
Can't locate Mail/SPF.pm in @INC (@INC contains:
/usr/lib/perl5/5.8.0/i386-linux-thread-multi /usr/lib/perl5/5.8.0
/usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi
/usr/lib/perl5/site_perl/5.8.0 /usr/lib/perl5/site_perl
/usr/lib/perl5/vendor_perl/5.8.0/i386-linux-thread-multi
/usr/lib/perl5/vendor_perl/5.8.0 /usr/lib/perl5/vendor_perl
/usr/lib/perl5/5.8.0/i386-linux-thread-multi /usr/lib/perl5/5.8.0 .) at
-e line 1.
BEGIN failed--compilation aborted at -e line 1.
[EMAIL PROTECTED] trunk]$
