http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5250
[EMAIL PROTECTED] changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From [EMAIL PROTECTED] 2007-01-23 02:10 -------
(In reply to comment #8)
> I'm not so thrilled with the submitted patch...
>
> There is no guaranteed blank line between the header and the body, so the
> regexp
> isn't necessarily going to do the right thing.
ok, good point. I'll look into that.
> Since the lower down rewrite functions are supposed to be private
> (rewrite_mail() is the standard API), we could just change them to return the
> header/body separately and then do the appropriate thing.
true. I wanted to avoid peppering that code with s// statements, and just have
"one big fixup" before return -- but maybe it would be better to do some
peppering instead.
> There's also the question of what to do with report_safe body content since we
> do want, imo, the line endings changed there. Perhaps we'd want it to return
> the components, set the appropriate areas to be line ending friendly, then
> reassemble...
that should be fixed already in the checked-in code; it fixes line endings
before inserting the (untouched) original-message message/rfc822 part.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
