http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5454


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
         AssignedTo|[email protected] |[EMAIL PROTECTED]




------- Additional Comments From [EMAIL PROTECTED]  2007-05-10 09:42 -------
(In reply to comment #5)
> We need to fix this ASAP, since the update is broken for people who have 
> disabled
> some of the default plugin set.

I'll be pushing an update later today to fix the 2 missing ifplugins in
72_scores.cf and the 102 (yes 102!) in the base release's 50_scores.cf.

> these are the default-active plugins, and the ones that the update currently
> requires.

The base release too! :(


(In reply to comment #11)
> yep, that would do it.  Note though that while I think it makes sense for this
> to be a non-lint-error situation, others may disagree ;)  let's see.

Yeah, I don't like that.  The rule update is broken, not the software.  If we
were to ignore the "score set for non-existent rule" lint errors, running a
normal "spamassassin --lint" on the system would fail -- quite possibly causing
problems with other things going on on that system.

If we're going to do anything, I'd add a --forceupdate option which would
install an update no matter how badly it fails to lint.  I'm a indifferent to
actually adding it though.  If it is added it needs to note that --forceupdate
was used in a comment in the channel .cf file (that includes all the rule files)
so that there's something to point at when somebody goes "hey, why'd your crappy
update screw up my install".


> (Also we'd still have to do the long-term fix -- some code to ensure that
> "ifplugin" lines are added to scores files in updates -- anyway.)

Working on it.  I've got management meetings the rest of the day though, so
it'll be sometime this evening before I get an update done (I had prepared one
by hand to fix the 2 missing ifplugin lines in 72_scores.cf then noticed the 102
missing ones in 50_scores.cf so I scraped the by hand idea).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

Reply via email to