http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5529
[EMAIL PROTECTED] changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4015 is|0 |1
obsolete| |
------- Additional Comments From [EMAIL PROTECTED] 2007-06-25 22:45 -------
Created an attachment (id=4023)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=4023&action=view)
Simple patch that should allow CPAN builds to work
This patch seems to be the minimum that would allow a CPAN install to work by
letting make test using the default settings in t/config.dist to run without
failures even if running as root in a directory that has no permissions for
non-root.
It sets umask to 022 if SATest.pm is run as root, it makes sure that t/log has
world read/execute permissions even if it exists already, and it creates a new
flag, $SKIP_SETUID_NOBODY_TESTS, that tests can use to skip execution if
running as root in a directory that non-root can't access.
For this patch, that last piece is still incomplete in that I only test for
running as root. Eventually I would like to actually setuid nobody and test
access to . and/or ./t/log and only conditionally set the flag. I also want to
create a tmp directory under those circumstances. Doing all that should allow
t/spamd_plugin.t to run under root. For now, this patch just disables that test
when running as root, which I think is a reasonable tradeoff.
Note that this patch does not allow the t/root*.t tests to be run in a
directory that does not provide world read/execute access. I don't disable the
tests when $SKIP_SETUID_NOBODY_TESTS is set because for now that would mean
never running them, and by default config.dist disables them.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
