http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5583

           Summary: Another unparsed Received line
           Product: Spamassassin
           Version: 3.2.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Libraries
        AssignedTo: [email protected]
        ReportedBy: [EMAIL PROTECTED]


IP address could not be extracted from the following Received header field,
which came in from the wild, but I have no idea from what system.
The syntax is close to standard (rfc2821), although missing TCP-info.

Received: from [86.122.158.69] by mta2.iomartmail.com;
  Thu, 2 Aug 2007 21:50:04 -0200

The attached patch fixes it. It also localizes $1..$6 which are
in use in sub parse_received_line, which can't hurt, but can
do good for a careless caller or to contain a Perl taint bug from
spreading. I think this should become a standard practice with
new code additions or when fixing existing code.

Btw, i think the sub parse_received_line needs a rewrite from scratch.
It should be able to parse rfc2821-compliant trace field without a
hitch (nested comments in CFWS, arbitrary order of option subfields,
IPv6, ...), then deal with whatever anomalies are known.
Something for the future...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to