[EMAIL PROTECTED] writes: > The Buildbot has detected a new failure of mc-fast. > Full details are available at: > http://bbmass.spamassassin.org:8011/mc-fast/builds/893 > > Buildbot URL: http://bbmass.spamassassin.org:8011/ > > Buildslave for this Build: mc-fast > > Build Reason: > Build Source Stamp: HEAD > Blamelist: mmartinec > > BUILD FAILED: failed test configure_2
mark -- looks like something needs fixing: http://bbmass.spamassassin.org:8011/mc-fast/builds/893/step-test/0 [/local/bbmasstools/masschroot /usr/local/bin/perl mass-check -c=tstrules --cache -j=1 --noisy --deencap='petuniapress.com' --cachedir=/tmpfs/aicache_bbmass --after='6 months ago' --tail=2000 ham:detect:/export/home/bbmass/rawcor/*/ham/* spam:detect:/export/home/bbmass/rawcor/*/spam/*] Undefined subroutine &Mail::SpamAssassin::Conf::untaint_var called at /slaves/mc-fast/mc-fast/build/masses/../blib/lib/Mail/SpamAssassin/Conf.pm line 2843. command '/local/bbmasstools/masschroot /usr/local/bin/perl mass-check -c=tstrules --cache -j=1 --noisy --deencap='petuniapress.com' --cachedir=/tmpfs/aicache_bbmass --after='6 months ago' --tail=2000 ham:detect:/export/home/bbmass/rawcor/*/ham/* spam:detect:/export/home/bbmass/rawcor/*/spam/*' failed with status 65280 at build/automc/run_preflight line 129. program finished with exit code 25 by the way, I'm not sure it's a good idea to use exported functions -- in my opinion it's easier to track down function source code when the full path to their module is specified: Mail::SpamAssassin::Util::untaint_var(...) vs. untaint_var(...) Also, does this impose a memory overhead by adding "untaint_var" to the package-local namespace of every module that loads it? if I recall correctly it does, whereas the nonexported version does not. (I may be wrong ;) --j.
