On Saturday September 15 2007 14:50:40 Justin Mason wrote: > We need an (SVN-only) .t test case that tests mass-check; it's pretty > vital during dev time.
Yes, would be very much welcome. > Mark -- a trivial test for mass-check: > > $ cd masses > $ ./mass-check -n -o ham:dir:. > Undefined subroutine &Mail::SpamAssassin::Conf::Parser::untaint_var called > at > /home/jm/ftp/sa/trunk/masses/../blib/lib/Mail/SpamAssassin/Conf/Parser.pm > line 617. Thanks, I just learned it. Ok, this now passes make test and mass-checks: svn ci Conf::Parser.pm: explicitly specify module name when calling sub untaint_var from anonymous subroutines which may be invoked in a context of modules; Util.pm: do not export subs local_tz, base64_decode and untaint_var by default, but use @EXPORT_OK and leave the decision to the importing module. Transmitting file data .... Committed revision 575915. > Daryl C. W. O'Shea writes: > > plugin: failed to parse plugin (from @INC): "untaint_var" is not > > exported by the Mail::SpamAssassin::Util module > > Can't continue after import errors at > > /home/dos/sa-mass-check/weekly_mass_check/masses/../lib/Mail/SpamAssassin > >/Plugin/MIMEHeader.pm line 68 Hmm. I wonder if it is now fixed by r575915. Sorry for the mess. Mark
