Daryl C. W. O'Shea writes:
> [EMAIL PROTECTED] wrote:
> > Author: jm
> > Date: Wed Sep 19 04:10:08 2007
> > New Revision: 577243
> > 
> > URL: http://svn.apache.org/viewvc?rev=577243&view=rev
> > Log:
> > if we hit an unreadable message file, skip it in client/server mode instead 
> > of killing the entire mass-check with 'Can't use an undefined value as an 
> > ARRAY reference at mass-check line 1181.'
> > 
> > Modified:
> >     spamassassin/trunk/masses/mass-check
> > 
> > Modified: spamassassin/trunk/masses/mass-check
> > URL: 
> > http://svn.apache.org/viewvc/spamassassin/trunk/masses/mass-check?rev=577243&r1=577242&r2=577243&view=diff
> > ==============================================================================
> > --- spamassassin/trunk/masses/mass-check (original)
> > +++ spamassassin/trunk/masses/mass-check Wed Sep 19 04:10:08 2007
> > @@ -1167,17 +1167,23 @@
> >  
> >    # Generate an archive in the temp file
> >    foreach my $num (@tosend) {
> > +    my $data = $msgsout->{$num}->{'data'};
> > +    my $msg;
> > +    if (!$paths_only) {
> > +      $msg = ($iter->_run_message($data))[4];
> > +      if (!$msg) {
> > +        warn "mass-check: _run_message returned undef! skipping";
> > +        next;
> > +      }
> > +    }
> > +
> 
> This won't work.  I did nearly the same thing and reverted it.  The 
> server will basically hang up trying to retry these messages.  The 
> outstanding message list needs to be dealt with to do this.
> 
> This was yet another thing I wanted to get to before being slammed with 
> "real" work this last week. :(

uh, crap.  The nightly mass-check on the zone is currently hosed because
ofthis bug, and I'm not going to be able to get to it either for a few
days, what with a massive switch of servers and an impending driving
test...

--j.

Reply via email to