Mark Martinec writes: > > It needs to be reverted asap. > > asap? Is anybody running trunk code under 5.6 ???
I don't know. It's good project hygiene to immediately fix any change that breaks "make test" or "make disttest" on a supported platform, and if a fix isn't practical in the short term, to at least revert it. > > Please test with perl 5.6.1 before committing... 5.6.1 and 5.8.x have > > radically different mechanisms to deal with UTF-8. > > This is kinda ugly, but it seems to be a practice in SpamAssassin > to depend on other modules to 'require' of 'use' needed external modules. well, that's probably not a great practice. Feel free to come up with a better alternative -- as long as it works with 5.6.1. ;) --j.
