Mark Martinec writes:
> svn -m 'add a call to $spamtest->finish in spamassassin.raw
> to allow plugins like HitFreqsRuleTiming to finish up their job' ci
> Sending spamassassin.raw
> Transmitting file data .
> Committed revision 595511.
>
> --- spamassassin.raw (revision 595501)
> +++ spamassassin.raw (working copy)
> @@ -287,6 +287,7 @@
> die "spamassassin: oops! unhandled whitelist operation";
> }
>
> + $spamtest->finish();
> exit(0);
> }
>
> @@ -383,6 +384,8 @@
> # if the eval died from something, report it here and return an error.
> if ($@) { die $@; }
>
> +$spamtest->finish() if $spamtest;
> +
> # Ok, exit!
> exit( $exitvalue || 0 );
>
>
>
> Is there any reason not to do so, or was it just considered unnecessary
> or was an omision? I find myself adding this call to spamassassin
> whenever I'd like to see what HitFreqsRuleTiming produces, without
> having to run mass-check (which does have a call to finish at it end).
an ommission -- all callers should call finish() for this reason.
> Should a Mail::SpamAssassin man page have a $spamtest->finish call
> at the end of its usage example?
yes definitely!
--j.
