http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5748
------- Additional Comments From [EMAIL PROTECTED] 2007-12-31 02:50 ------- (In reply to comment #25) > What all that seems to mean is that the correct fix for this bug is to stay > with > the original code but simply change "sort $FILE |" to $FILE. > > Could it be that simple? yes ;) rule2xs() is an adaptation of some code contributed by Matt Sergeant from a command-line script, so it has a few vestigial features that used to be command line switches in the original -- such as $force, and the if (!$modname) check about 15 lines in. Nowadays, in our code, it's only called from the rest of sa-compile, so those command line args and input sanitizations are redundant (and should be refactored out at some stage). Looking at it now, I can see that -- yes -- that sort(1) invocation was also redundant, since all the input is in the correct order already. so go for it ;) ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
