http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5817
------- Additional Comments From [EMAIL PROTECTED] 2008-02-14 19:52 ------- (In reply to comment #10) > It's just not clear to me why you're mixing > substr with regexes and then testing if $helo has a value after you've already > tried to take a substr of it. To clarify further: The substr() does not alter $helo. The first substr() with the RE test merely gets rid of the leading and trailing '!' for the RE match, necessary because IP_PRIVATE is anchored at the beginning. The subsequent test if $helo actually holds a value at all is unrelated. The order of these two tests are irrelevant. I settled for the order as is, to first return 0 in the cases where the relay is valid, and then to check for the remaining conditions that identify what the plugin is supposed to catch. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
