https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5959
Summary: URIDetail broken due to rule de-duplication code
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Plugins
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
Internally, the URIDetail plugin converts each "uri_detail" rule to a body eval
rule that runs "check_uri_detail()". Different invocations of this function
give different results because it checks $pms->{current_rule_name} and it uses
the rule name to look up the actual definition of the rule in the config.
The "merge duplicate rules" code, as it's currently implemented, merges
together rules with the same "definition", so only one uri_detail rule ever
gets run. Obviously, this is a bad thing. It's pretty straightforward to fix
the URIDetail plugin, but it's likely that there are third party plugins that
work the same way, and it's definitely a gotcha for Plugin creators.
I would suggest that the "merge duplicates" code should be limited to regex
rules. It seems useful to have multiple (different) rules that run the same
eval rule code with the same (or no) arguments.
--
Configure bugmail:
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
