https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6060





--- Comment #4 from Mark Martinec <mark.marti...@ijs.si>  2009-02-06 11:00:41 
PST ---
> use_rule_subs is very useful for profiling, as it exposes each rule as an
> individual subroutine.

Here is a count of calls to got_hit in the eval-ed code on our installation,
by type and priority (as given as arguments to eval in the current code):

full_500.pm      3
uri_500.pm       6
rawbody_500.pm  15
head_500.pm     18
full_0.pm       25
uri_0.pm       294
rawbody_0.pm   431
meta_500.pm    736
head_0.pm     1855
body_0.pm     5224

Now that I think of it, a combined approach similar to use_rule_subs
would satisfy both needs: not give Perl too large chunks of code
to compile, and save on memory footprint in a parent process
(inherited by child processes) for source code, as Bug 5876 is
trying to solve.

But instead of one rule per subroutine (as with use_rule_subs)
or all rules in one subroutine (as without use_rule_subs),
perhaps 100 rules per sub would be a good compromise, cleanly
satisfying both needs, and without going into complications
with temporary files. (btw, only generic rules are of issue
here, the run_eval_tests is not problematic).

Justin (as you are more intimately familiar with this code),
can you think of a change which could achieve this?


-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to