> > Did a diff between the tarball and the trunk. Possibly some of > > the following missing files should be listed in MANIFEST > > to find their way into the package [...]
Justin writes: > The build files and the top level dirs can all be excluded. I tried re-creating the MANIFEST from scratch, then removing the move obvious entries (comparing with MANIFEST in 3.2.5 and 3.3.0), sorted alphabetically, so this is the diff: --- Mail-SpamAssassin-3.3.0/MANIFEST 2009-12-03 06:11:05.000000000 +0100 +++ spamassassin-trunk/1.lis 2009-12-04 20:40:09.000000000 +0100 @@ -7,4 +7,4 @@ MANIFEST.SKIP -Makefile.PL META.yml +Makefile.PL NOTICE @@ -15,10 +15,2 @@ USAGE -build/check_dependencies -build/convert_pods_to_doc -build/get_version -build/md5sum.pl -build/mkrules -build/parse-rules-for-masses -build/preprocessor -build/sha1sum.pl ldap/README @@ -90,5 +82,8 @@ lib/Mail/SpamAssassin/Plugin/MIMEHeader.pm +lib/Mail/SpamAssassin/Plugin/NetCache.pm lib/Mail/SpamAssassin/Plugin/OneLineBodyRuleType.pm +lib/Mail/SpamAssassin/Plugin/P595Body.pm lib/Mail/SpamAssassin/Plugin/PhishTag.pm lib/Mail/SpamAssassin/Plugin/Pyzor.pm +lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm lib/Mail/SpamAssassin/Plugin/Razor2.pm @@ -118,2 +113,3 @@ lib/Mail/SpamAssassin/Util/DependencyInfo.pm +lib/Mail/SpamAssassin/Util/MemoryDump.pm lib/Mail/SpamAssassin/Util/Progress.pm @@ -124,6 +120,9 @@ procmailrc.example +rules/STATISTICS-set0.txt +rules/STATISTICS-set1.txt +rules/STATISTICS-set2.txt +rules/STATISTICS-set3.txt +rules/active.list rules/init.pre rules/languages -rules/local.cf -rules/regression_tests.cf rules/sa-update-pubkey.txt @@ -230,2 +229,3 @@ t/cpp_comments_in_spamc.t +t/cross_user_config_leak.t t/data/01_test_rules.cf @@ -294,2 +294,7 @@ t/data/nice/base64.txt +t/data/nice/cjk/big5-base64.1 +t/data/nice/cjk/gb2312.1 +t/data/nice/cjk/gb2312.2 +t/data/nice/cjk/iso-2022-jp.1 +t/data/nice/cjk/iso-2022-jp.2 t/data/nice/crlf-endings @@ -363,2 +368,4 @@ t/data/whitelists/debian_bts_reassign +t/data/whitelists/ibm_enews_de +t/data/whitelists/infoworld t/data/whitelists/linuxplanet @@ -371,2 +378,4 @@ t/data/whitelists/netcenter-direct_de +t/data/whitelists/netsol_renewal +t/data/whitelists/networkworld t/data/whitelists/oracle_net_techblast @@ -381,2 +390,3 @@ t/db_awl_path.t +t/db_awl_perms.t t/db_based_whitelist.t @@ -398,2 +408,3 @@ t/html_utf8.t +t/if_can.t t/ifversion.t @@ -404,2 +415,4 @@ t/lint_nocreate_prefs.t +t/make_install.t +t/mass_check.t t/memory_cycles.t @@ -445,2 +458,3 @@ t/sa_check_spamd.t +t/sa_compile.t t/sha1.t @@ -496,4 +510,6 @@ t/spamd_utf8.t +t/spamd_whitelist_leak.t t/spf.t t/sql_based_whitelist.t +t/stop_always_matching_regexps.t t/strip2.t @@ -517,7 +533 @@ t/zz_cleanup.t -t/spamd_whitelist_leak.t -t/db_awl_perms.t -t/stop_always_matching_regexps.t -t/cross_user_config_leak.t -t/if_can.t -t/sa_compile.t Would this make sense? Some specific questions: * should these be listed? +lib/Mail/SpamAssassin/Plugin/NetCache.pm +lib/Mail/SpamAssassin/Plugin/P595Body.pm +lib/Mail/SpamAssassin/Plugin/RabinKarpBody.pm +lib/Mail/SpamAssassin/Util/MemoryDump.pm * what about the following, they go in or out? +rules/STATISTICS-set0.txt +rules/STATISTICS-set1.txt +rules/STATISTICS-set2.txt +rules/STATISTICS-set3.txt +rules/active.list -rules/local.cf -rules/regression_tests.cf * what about directories lm and xt ? Mark
