https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6246
Mark Martinec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Undefined |3.3.0 --- Comment #1 from Mark Martinec <[email protected]> 2009-12-04 18:51:05 UTC --- > re: 3.3.0 beta1, I generally don't like seeing a release go out that has known > make test failures. > > Currently, I'm failing on this: > > t/dkim2...........................ok 32/123 Not found: > DKIM_ADSP_NXDOMAIN = DKIM_ADSP_NXDOMAIN at t/dkim2.t line 85. > # Failed test 120 in t/SATest.pm at line 716 > > Turning on verbose tests, I found this output: > Checking for anti-pattern DKIM_ADSP_ALL at t/dkim2.t line 85. > *** Mail::DKIM 0.36, Test 120 is expected to fail with versions > older than 0.36_5 > I'd like to either A) see that warning in non-verbose tests, I do see the explanation line ("...is expected to fail...") even on plain 'make test' run (not only on prove -v t/dkim2.t): t/dcc.t ........................... ok t/debug.t ......................... ok t/desc_wrap.t ..................... ok t/dkim.t .......................... skipped: (no reason given) t/dkim2.t ......................... 69/123 Not found: DKIM_ADSP_NXDOMAIN = DKIM_ADSP_NXDOMAIN at t/dkim2.t line 85. # Failed test 120 in t/SATest.pm at line 716 *** Mail::DKIM 0.31, Tests 105, 109, 113, 117, 120 are expected to fail with versions older than 0.34 t/dkim2.t ......................... Failed 1/123 subtests t/dnsbl.t ......................... ok t/dnsbl_sc_meta.t ................. ok > B) Makefile.PL modified on line 185 to say 'Mail::DKIM' => 0.36_5, > I suggest solution B and submitting a patch for this purpose. > Created an attachment (id=4585) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4585) [details] > Very Simple Patch to require a newer DKIM module for install of SA Making Mail::DKIM 0.37 a required minimal version is indeed the easiest way out, but perhaps not everybody would appreciate it (even though this version is out for 3 months now). I went to considerable lengths to make the DKIM plugin 'mostly usable' even with old versions of Mail::DKIM (see Bug 6100), and at that time we agreed that 0.31 is the oldest usable. Making 0.37 a minimal required version would be fine with me, if we can collect enough votes and no vetoes, which might be tricky. > or C) see a warning > from the Makefile.PL advising they upgrade if not require it before I +1. The release notes document it: - CPAN module requirements: - minimal version of Mail::DKIM is 0.31 (preferred: 0.36_5 or later) [...] DKIM PLUGIN - absolute minimal version of Mail::DKIM is 0.31; support for ADSP requires Mail::DKIM 0.34; a DNS test (and rule) for NXDOMAIN is operational since Mail::DKIM 0.36_5 Perhaps the Mail/SpamAssassin/Util/DependencyInfo.pm could be enhanced to report recommended versions of modules, when not met. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
