https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6176

--- Comment #7 from Mark Martinec <[email protected]> 2009-12-17 06:29:14 
UTC ---
(In reply to comment #6)
> Created an attachment (id=4608)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4608) [details]
> truncate without message fix V2

+ if( (option[strlen(option)-1] != '\n') && (!feof(config)) ) {

Hmm, fgets could conceivably return an empty string (null at index 0),
so strlen(option)-1 could yield a -1. Better to be safe and test
the length first.

> Ok. Here is the second version. Does apply to trunk (without my first patch).
> And again with the not wanted <CRs>. Sorry, don't know how to easily get rid 
> of
> that.

No problem, we just need to be careful when applying a patch.

> First version had a problem that it exited to early (in case of -V).

Thanks.

> Also, applied larger line maximum (257). But, that's your decision.

Good. I don't mind any reasonably large value. Justin's 8k is good too.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to