https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6228
--- Comment #17 from Anthony Foiani <[email protected]> 2009-12-17 07:28:49 UTC --- (In reply to comment #16) > Does this last patch to Plugin/Bayes.pm succeed in stashing a ref > to a 'store' into both places and the patch to sa-learn isn't needed? No, it doesn't. Sorry, I should have been more clear. The rest of the patch is still useful; keeping $store in scope across the entire function is better than assigning it individually inside each branch of the 'if'. That's somewhat a taste issue, but the ability to add better logging/tracing is a technical argument in its favor. As for trying to stash $store in both places ... I suspect that this patch could be made to work (and hence get rid of the hack in sa-learn). I'm either not putting it in the correct place, or one of the values in this chain: $self->{main}->{bayes_scanner}->{store} Is getting overwritten sometime after 'learner_new' is called. So I probably should have left that commented out. Sorry about that. Someone who understands the invocation order and relationships between the different objects should be able to make this work, and hence not need the ugly hack in sa-learn. Does that make sense? -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
