https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5895
--- Comment #10 from Mark Martinec <[email protected]> 2010-01-05 05:21:24 UTC --- (In reply to comment #8) > It looks like originating_ip_headers and clear_originating_ip_headers have to > be added to the list in t/cross_user_config_leak.t just like trusted_networks > and clear_trusted_networks or else that test fails. But that is just updating > the test case, not a problem with the patch. The Parser.pm claims: It is good practice to set a 'type', if possible, describing how your settings are stored on the Conf object; this allows the SpamAssassin test suite to validate that the settings do not 'leak' between users. so I'd say that a: type => $CONF_TYPE_STRING, should be added to the originating_ip_headers and clear_originating_ip_headers setting, not the test tweaked. (or better yet, a $CONF_TYPE_NOARG type invented for settings like clear_headers, clear_trusted_networks, clear_internal_networks, clear_msa_networks, clear_originating_ip_headers, clear_report_template, clear_unsafe_report_template) -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
