https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6393
Justin Mason <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Justin Mason <[email protected]> 2010-03-31 11:13:39 UTC --- (In reply to comment #10) > Ah, right, it was not that unconditionally as I thought. grep doesn't provide > sufficient context. ;) > > Anyway, there's a similar one in M::SA::BayesStore::DBM. File::Basename is > use'd inside the eval{} in sub perform_upgrade, as well as unconditionally in > the entire package. Yeah. I'm not as concerned about that, we use Basename a lot throughout the codebase. : 57...; grep -r Basename lib | grep -v .svn lib/Mail/SpamAssassin/Util.pm:use File::Basename; lib/Mail/SpamAssassin/AICache.pm:use File::Basename; lib/Mail/SpamAssassin/BayesStore/DBM.pm:use File::Basename; lib/Mail/SpamAssassin/BayesStore/DBM.pm: use File::Basename; lib/Mail/SpamAssassin/BayesStore/BDB.pm:use File::Basename; lib/Mail/SpamAssassin/Plugin/Hashcash.pm:use File::Basename; lib/Mail/SpamAssassin.pm:use File::Basename; > +1 on the patch, I guess. thanks! : 54...; svn commit -m "bug 6393: make File::Copy module load conditional on 'sa-learn --upgrade' with DBM files, not very commonly used" lib/Mail/SpamAssassin/BayesStore/DBM.pm lib/Mail/SpamAssassin.pm Sending lib/Mail/SpamAssassin/BayesStore/DBM.pm Sending lib/Mail/SpamAssassin.pm Transmitting file data .. Committed revision 929478. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
