https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6454

Kevin A. McGrail <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Kevin A. McGrail <[email protected]> 2010-06-16 12:39:42 
EDT ---
(In reply to comment #1)
> Created an attachment (id=4777)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4777) [details]
> suggested fix
> 
> trunk:
>   Bug 6454: wrong status test on $sth->rows in BayesStore::PgSQL
> Sending lib/Mail/SpamAssassin/BayesStore/PgSQL.pm
> Committed revision 955092.

I'm not voting on this issue but worried the patch could have unanticipated
consequences.
DBI can return 0E0 "If no rows were affected, then "execute" returns "0E0",
which Perl will treat as 0 but will regard as true."

0E0 will eval to true because it's a string.  

I am concerned when I saw you remove the check on '0E0' as being a possible
problem and wondered if you new about this silly return code issue and why it
is/isn't an issue here.

Regards,
KAM

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to