https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6506
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status Whiteboard|needs 1 vote for 3.3 branch |ready to commit --- Comment #3 from Kevin A. McGrail <[email protected]> 2010-11-30 14:49:55 UTC --- (In reply to comment #2) > (In reply to comment #0) > > Found the following code section in Plugin/DNSEval.pm: > > Ugh, that was ugly. > > > Suggesting the following replacement: > > > > # remove trusted hosts from beginning > > while (@ips && $trusted->contains_ip($ips[0])) { shift @ips } > > +1 for the 3.3 branch > > As usual, I reviewed the code, didn't actually run it. The proposed > replacement > looks much clearer, though, and is logically, err, not prone to break. Ditto and +1 for the 3.3 branch -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
