https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6519
--- Comment #4 from Mark Martinec <[email protected]> 2010-12-01 06:04:53 UTC --- > In the patch: > $revip = lc $ip_obj->network->full6; > The lc operation is not necessary, but it won't cause incorrect results > leaving it in. It should be removed for speed. DNS labels are case > insensitive, so we need not force lower case. Well, it is true that DNS labels are case insensitive, and neither does the RFC 4291 prefer one case over another. The reversed address still shows up in the logs and the DNS query. I chose the lowercase form because RFC 5782 uses lowercase in its example, and because RFC 5952 (A Recommendation for IPv6 Address Text Representation) recommends the lowercase form (SHOULD): 4. A Recommendation for IPv6 Text Representation A recommendation for a canonical text representation format of IPv6 addresses is presented in this section. The recommendation in this document is one that complies fully with [RFC4291], is implemented by various operating systems, and is human friendly. The recommendation in this section SHOULD be followed by systems when generating an address to be represented as text, but all implementations MUST accept and be able to handle any legitimate [RFC4291] format. It is advised that humans also follow these recommendations when spelling an address. [...] 4.3. Lowercase The characters "a", "b", "c", "d", "e", and "f" in an IPv6 address MUST be represented in lowercase. [...] 3.4.3. Legibility Capital case D and 0 can be quite often misread. Capital B and 8 can also be misread. > It should be removed for speed. Oh, c'mon! It's a single perl opcode - in contrast with thousands of opcodes in the called subroutines on the same line. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
