https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6558
--- Comment #15 from Mark Martinec <[email protected]> 2011-03-23 16:33:38 EDT --- Created an attachment (id=4859) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4859) let sa-update issue a warning when stumbling across a rule which could hit bug 6558 Guenther wrote on the ML: > Can we come up with some (brief) instructions, and a test rule that > should trigger the bug? So we can have those previously effected verify > it, and more importantly, verify the (tiny) patch to fix the issue for > them? A test case to be sure, whether or not future rule updates even > would include what's just broken the compile? > Also, while this Perl bug is out there (which undoubtful will exists for > a long time on production machines), should we refrain from tflags > multiple body rules? I guess so. > Though yeah, agreed, a lint check at least for Jenkins to catch > inappropriate tflags multiple for body rules and version <3.3.2 sounds > like a good precaution. Might back-fire, though, due to generated > scores. In the worst case, this is scorched earth until 3.4. :( Attached is a patch to BodyRuleBaseExtractor.pm which will make sa-compile report a warning when hitting a rule with tflag=multiple and a lossy match. Appropriate for Jenkins runs. E.g. (hand wrapped and cleansed): # sa-compile Mar 23 21:19:07.288 [9363] info: generic: base extraction starting.... Mar 23 21:19:07.288 [9363] info: generic: extracting from rules of ... zoom: rule __PILL_PRICE_3 will loop on SpamAssassin older that 3.3.2 running under Perl 5.12 or older, Bug 6558 zoom: rule __PILL_PRICE_1 will loop on SpamAssassin older that 3.3.2 running under Perl 5.12 or older, Bug 6558 zoom: rule __PILL_PRICE_2 will loop on SpamAssassin older that 3.3.2 running under Perl 5.12 or older, Bug 6558 trunk: Bug 6558: let sa-update issue a warning when stumbling across a rule which could hit this bug Sending lib/Mail/SpamAssassin/Plugin/BodyRuleBaseExtractor.pm Committed revision 1084721. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
