https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6565
--- Comment #3 from Mark Martinec <[email protected]> 2011-05-04 19:19:29 UTC --- > Created attachment 4867 [details] > Fix > > For 41 check_rbl_sub rules, changed regexes to exact equality, or added > escapes, begin and end markers, where appropriate. > > Also made a minor correction to a DNSWL rule description. Nice job, thanks! Fine with me to apply this to 3.3. Seems you have missed the: 20_dnsbl_tests.cf header RCVD_IN_XBL eval:check_rbl('zen-lastexternal', 'zen.spamhaus.org.', '127.0.0.[45678]') possibly others. Actually what I wrote earlier: > What is not true is that an eval:check_rbl_sub(..., '127.0.0.1') needs > fixing. It doesn't, see Mail::SpamAssassin::Dns::process_dnsbl_set : > not all arguments to check_rbl_sub are regular expressions. The subroutine > tests first for exact equality, then checks for a single integer > (which implies a bitmask), and only if all this fails, the argument > is considered a regular expression. ...is how it is supposed to work and it's how it is documented. Yet the implementation is wrong: if the exact match fails, it falls onto a regexp test, even when a 'subtest' is a dotted-quad. The attached patch should fix it. trunk: $ svn ci -m 'Bug 6565: The dotted-quad subtest should not be interpreted as a regexp' Sending lib/Mail/SpamAssassin/Dns.pm Committed revision 1099562. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
