https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6619
Bug #: 6619
Summary: [review] sa-update gives misleading "required" error
on systems without gpg
Product: Spamassassin
Version: 3.3.2
Platform: PC
OS/Version: Windows 7
Status: NEW
Severity: normal
Priority: P2
Component: sa-update
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
This is a follow-up on bug 6618 which was hijacked a bit.
The problem is that sa-update says gpg is required which is not 100% accurate.
I've added additions to DependencyInfo.pm to test for required/optional
binaries such as gpg.
The test_version subroutine might be reinventing the wheel or doing things very
much the hard way so I would appreciate input there.
If you remove gpg, from your path (or change your path), all you have to do for
a test is perl Makefile.PL [email protected]
Would be good if you can play with the required/recommended versions and test
as well with gpg in the path.
The goal of this patch is to prompt that the optional gpg binary is not
installed and let the end-user know this is required for sa-update to verify
the encryption signature.
It also gives a framework built off the existing MODULES and OPTIONAL_MODULES
functionality for binaries in case we need to require/test for additional
binaries.
sa-update is also updated to clarify that --nogpg can be used although not
recommended.
--
Configure bugmail:
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
