https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6683
Bug #: 6683
Summary: RuleQA is sorting masschecks lexically instead of
numerically
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: RuleQA
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
Created attachment 4985
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4985
patch
It's sorting by revision number, and it's sorting lexically (alphabetically)
when it should be sorting numerically, resulting in stuff being out of order:
783698: 2009-06-11 08:50:01
783256: 2009-06-10 08:50:02
1189081: 2011-10-26 08:50:01
1188569: 2011-10-25 08:50:02
1188045: 2011-10-24 05:57:16
This is most noticeable in the "most recent 1000" view:
http://ruleqa.spamassassin.org/?longdatelist=1#r20111022_r1187674_n
This patch is not tested, because I fear the process of setting up a sufficient
test environment. I also haven't extensively studied the code to make sure the
relevant function never gets passed non-numeric values to sort.
But I'm hoping the fact that the key always comes from $meta->{rev} is
sufficient indication that it's always a revision number. And potential
breakage should be very minimal, easily noticeable, and easily reverted.
--
Configure bugmail:
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
