https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6456
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4786|0 |1 is obsolete| | --- Comment #6 from Kevin A. McGrail <[email protected]> 2011-10-31 21:40:51 UTC --- Created attachment 5002 --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=5002 Revised patch to use sprintf with variable placeholder for delimiter (In reply to comment #5) > (In reply to comment #4) > > In both cases I'm not sure though, if there is any negative effect on Mac OS > > systems, which uses CR rather than LF (Unix) or CRLF (Windows). Is that even > > still true since Mac OS X? > > Sorry, should have spent another minute before commenting. > > Mac OS up to version 9 uses CR. Mac OS X of course uses LF, like any Unix-like > system, such as Linux and *BSD. Using PerlIO :crlf over complicates things. The delimiter code is only for logging and we just want to change logging to be a bit better. His code fixes that for windows in the most centralized way I can think of by changing the errors and log_message code in File.pm and Stderr.pm. In most unix boxes, it'll use Stderr.pm and switch to Syslog.pm so this shouldn't be an efficiency issue. If you really want to support OS9, Util.pm should have functionality added to it. However, OSX is now over 10 years old. OS9 support is not needed IMO. Attached patch won't pass make test, though. What am I doing wrong...? -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
