https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6549
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #6 from Kevin A. McGrail <[email protected]> 2011-12-12 17:07:48 UTC --- (In reply to comment #5) > My only hesitation with that code is the /(${IP_ADDRESS}).{10,80}/ part, > where ".{10,80}" could conceivably continue the IP given the lack of a > delimiter. The IP_ADDRESS constant ends with (?![a-f0-9:]) but lacks a > IPv4-ish equivalent, thus allowing mathces like "1.2.3.4.example.com" or even > "1.2.3.4.5" > > This regex is the only one that contains an ambiguous ending to an IP matcher, > at least that I could find with /IP_ADDRESS\}?\)?[\[.]/ > > > This really should be a change to IP_ADDRESS itself, but for consistency, I'd > like to change the regex here to include a space after ${IP_ADDRESS} Sounds good to me. The test cases should show if that works and perhaps add an extra test that is bogus. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
