https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6798
--- Comment #2 from Mark Martinec <[email protected]> --- > Created attachment 5073 [details] > defines several missing POSIX macros for Windows Nitpicking, but: > *WIFEXITED = sub { not $_[0] & 0xff }; Should't this be: (the WCOREFLAG bit should be ignored) *WIFEXITED = sub { not $_[0] & 127 }; > *WIFSIGNALED = sub { $_[0] & 127 }; Shouldn't this be: (the _WSTOPPED value should be excluded) *WIFSIGNALED = sub { ($_[0] & 127) && ($_[0] & 127 != 127) }; Perhaps this chunk of code (conditionally defining the missing functions) should be enclosed in a BEGIN { ... } block, so that subroutines are available early to the rest of the program. > Attached a patch that also reverses the changes from bug 6470 as we can use > the signals now (tested, cleanup of spamd child was now determined with the > correct exit status). Good! Btw (not knowing much about Windows), shouldn't a GetExitCodeProcess() be used on Windows instead of WEXITSTATUS ? -- You are receiving this mail because: You are the assignee for the bug.
