https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6508
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |[email protected] Resolution|--- |FIXED --- Comment #8 from Kevin A. McGrail <[email protected]> --- (In reply to comment #7) > To recap: the Net::Patricia support is done and works well, > what is still needed is to polish the t/trust_path.t test > which unnecessarily fails in the presence of Net::Patricia, > or at least document the fact in 3.4.0 release notes. After working on this for a few hours, I think there are some caveats with using Net::Patricia that are not well documented. However, it appears the cases that fail in trust_path.t are incompatibilities with the syntax for {trusted,internal,msa}_networks. I'm adding some code to avoid the checks if Net::Patricia is installed and some documentation warning regarding the syntax for Net::Patricia not being as flexible as NetAddr::IP with overlapping networks. I believe we can safely call it poorly configured for the admins technical enough to want to utilize Net::Patricia. If it becomes more prevalent though we might want to figure out a lint warning for all of the syntaxes that aren't supported. Committing and closing. And I can now do a make test on trunk with every single optional module installed. This also works with and without Net::Patricia though I'll test it on an older perl after the commit and report back if there is a problem. svn commit -m 'Net::Patricia not as flexible as NetAddr::IP with overlapping networks. Updated documentation to help make this more apparent and also fixed trust_path.t to avoid tests for incompatible syntaxes.' Sending lib/Mail/SpamAssassin/Conf.pm Sending lib/Mail/SpamAssassin/Util/DependencyInfo.pm Sending t/trust_path.t Transmitting file data ... Committed revision 1373194. Regards, KAM -- You are receiving this mail because: You are the assignee for the bug.
