https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6703
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #38 from Kevin A. McGrail <[email protected]> --- (In reply to comment #37) > (In reply to comment #36) > > mass_checks child process: > > mass_checks::generate_queue > > -> ArchiveIterator::_scan_targets > > -> ArchiveIterator::_set_default_message_selection_opts > > (sets opt_from_regex for a child process) > > > > mass_checks parent process: > > waits for child; > > mass_checks::run_post_scan > > -> run_through_messages > > --> $iter->_run_message (runs with an undefined opt_from_regex) > > > This is also happening to Marc Andre Selig. > > I think we need to revert the patches related to this, see if mbox numbers > improve and then figure out a masscheck safe way to implement the fixes. > > That's commits 1350839 & 1354072 however fundamentally, I thought I set a > sane default for the option and this is confusing me a lot. The issues with masscheck and archiveiterator are related and at the same time unrelated. IMO, we are improperly using the ArchiteIterator class without calling _set_default_message_selection_opts which is where I set the sanity check for the opt_from_regex. I think this should be called from new when the class is constructed rather than rely on someone using the API to call it. However, bowing to existing structure, I have added a call to _set_default_message_selection_opts in mass-check.sh. I've checked and this change appears to be the fix. Index: masses/mass-check =================================================================== --- masses/mass-check (revision 1373195) +++ masses/mass-check (working copy) @@ -419,6 +419,9 @@ $iter->set_functions(\&wanted, \&result); } +#AFTER SETTING ALL OPTS, RUN _set_default_message_selection_opts() TO GET SANE DEFAULTS +$iter->_set_default_message_selection_opts(); + my $messages; # normal mode as well as a server do scan mode and get a temp file svn commit -m 'change to mass-check to get ArchiteIterator sane defaults like the from separator' Sending lib/Mail/SpamAssassin/ArchiveIterator.pm Sending masses/mass-check Transmitting file data .. Committed revision 1373202. -- You are receiving this mail because: You are the assignee for the bug.
