https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6845

--- Comment #7 from John Hardin <[email protected]> ---
(In reply to comment #6)
> The patch seems straightforward but can you think of any way to add t/ tests
> to check this code to make sure it doesn't have a larger impact than
> intended?

I'm not experienced in writing Perl test cases, but I'm sure it can be done. :)

I did run it through a make test and fixed one minor issue (I initially assumed
@message would never be empty); all existing tests pass.

A test case that expresses the problem (i.e. fails when the patch is not
present) is easy to design; figuring out what it might screw up is a little
more complicated. I went through my corpus looking for properly-formatted
multipart messages, and didn't see any possibilities where inserting a blank
line at the head this way would be an obvious problem.

I'll take a look at the existing tests and see if any of them can be easily
leveraged to add some cases that would indicate if this caused problems.
Suggestions solicited.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to