https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6817
--- Comment #15 from Kevin A. McGrail <[email protected]> --- (In reply to comment #14) > (In reply to comment #9) > > > #SHOULD HIT > > $name[1] = '[email protected]'; > > IMO that shouldn't hit. mr. in an address could just be a jokey address. > It's completely different from "Mr John Smith" which is a misplaced attempt > at professional formality. Yeah, it's taken a bit to think about what should and shouldn't hit. But if if my theory is correct, the current 3.4 trunk WON'T hit on that because it doesn't have a name portion. So "Mr. Fix It" <[email protected]> would hit but <[email protected]> would not because Name portion is blank. Not sure if that's still going to reduce FPs so step 1 is lowering the scores. Step 2 is likely to figure out what are some examples that should and should not hit based on 3.4 and improve the rule. I'm planning on committing a version based if loop on the rule and lower score ceilings for masscheck soon. Failed a make test for something else so I'm working on that. Index: rulesrc/sandbox/hege/20_hk.cf =================================================================== --- rulesrc/sandbox/hege/20_hk.cf (revision 1421841) +++ rulesrc/sandbox/hege/20_hk.cf (working copy) @@ -124,15 +124,25 @@ ifplugin Mail::SpamAssassin::Plugin::FreeMail -header __HK_NAME_MR_MRS From:name =~ /^M(?:RS?|ISS)\b/mi +#REQUIRING VERSION 3.4 BECAUSE From:name works improperly prior to that version. +if (version >= 3.004000) + header __HK_NAME_MR_MRS From:name =~ /^M(?:RS?|ISS)\b/mi + meta HK_NAME_MR_MRS __HK_NAME_MR_MRS && !FREEMAIL_FROM + score HK_NAME_MR_MRS 2.0 + meta HK_NAME_FM_MR_MRS __HK_NAME_MR_MRS && FREEMAIL_FROM + score HK_NAME_FM_MR_MRS 3.0 +endif + header __HK_NAME_DR From:name =~ /^DR\b/mi header __HK_NAME_FROM From:name =~ /^FROM\b/mi -meta HK_NAME_MR_MRS __HK_NAME_MR_MRS && !FREEMAIL_FROM -meta HK_NAME_FM_MR_MRS __HK_NAME_MR_MRS && FREEMAIL_FROM meta HK_NAME_DR __HK_NAME_DR && !FREEMAIL_FROM +score HK_NAME_DR 2.0 meta HK_NAME_FM_DR __HK_NAME_DR && FREEMAIL_FROM +score HK_NAME_FM_DR 3.0 meta HK_NAME_FROM __HK_NAME_FROM && !FREEMAIL_FROM +score HK_NAME_FROM 2.0 meta HK_NAME_FM_FROM __HK_NAME_FROM && FREEMAIL_FROM +score HK_NAME_FM_FROM 3.0 endif -- You are receiving this mail because: You are the assignee for the bug.
