https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6655
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #15 from Kevin A. McGrail <[email protected]> --- (In reply to comment #14) > Are there any notes in the INSTALL or some such to let people know that > having > one of curl, wget or fetch installed is a good idea? Solaris 10 does have > wget > in /usr/sfw/bin, but that is not in the path by default. Good point! I've added code to the INSTALL and to DependencyInfo.pm to check for the binaries. IMPORTANT: Anyone have fetch or can point me to a link to donwnload so I can identify a good recommend version and the regex check for the version info? Index: INSTALL =================================================================== --- INSTALL (revision 1428441) +++ INSTALL (working copy) @@ -89,6 +89,10 @@ See the "Installing Rules" section below if you do not wish to download the rules directly from the internet. + NOTE: Because LWP does not support IPv6, sa-update as of 3.4.0 will use + the binaries curl, wget or fetch to download rule updates with LWP used + as a fallback if none of the binaries exist. + 5. If you already use procmail, skip to step 7. If not, ensure procmail is installed using "which procmail" or install it from www.procmail.org. Index: lib/Mail/SpamAssassin/Util/DependencyInfo.pm =================================================================== --- lib/Mail/SpamAssassin/Util/DependencyInfo.pm (revision 1428441) +++ lib/Mail/SpamAssassin/Util/DependencyInfo.pm (working copy) @@ -258,6 +258,10 @@ my @BINARIES = (); +my $lwp_note = " Because LWP does not support IPv6, sa-update as of 3.4.0 will use + the binaries curl, wget or fetch to download rule updates with LWP used + as a fallback if none of the binaries exist."; + my @OPTIONAL_BINARIES = ( { binary => 'gpg', @@ -268,6 +272,23 @@ desc => 'The "sa-update" program requires this executable to verify encryption signatures. It is not recommended, but you can use "sa-update" with the --no-gpg to skip the verification. ', +}, +{ + binary => 'wget', + version => '0', + recommended_min_version => '1.8.2', + version_check_params => '--version', + version_check_regex => 'Gnu Wget ([\d\.]*)', + desc => $lwp_note, +}, + +# I DO NOT HAVE FETCH TO CHECK. +{ + binary => 'fetch', + version => '0', + version_check_params => '--version', + version_check_regex => 'fetch ([\d\.]*)', + desc => $lwp_note, } ); svn commit -m 'Documentation in INSTALL and DependencyInfo.pm because sa-update now uses binaries before LWP for better ipv6 support - bug 6655' Sending INSTALL Sending lib/Mail/SpamAssassin/Util/DependencyInfo.pm Transmitting file data .. Committed revision 1428581. Leaving open to identify the information for fetch. Only fetch program I know is a commercial proggy for macs. Is that the one we are talking about? -- You are receiving this mail because: You are the assignee for the bug.
