https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6877
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Kevin A. McGrail <[email protected]> --- Hendrik, these are pretty simple changes AND you included samples so I can work with them. However, some important notes: 1 - Your patches made the work a lot harder. You should look at using something like the command diff -ruN to provide a unified diff. It puts changes in much better context as I had to A) figure out the files that were being modified and B) figure out what line number I thought would be best. 2 - Don't synthesize headers. Copy them from your examples, put them in the rcvd_parser.t and see what they get. From my tests, the HTTP version appears to already be working and that portion of your first edit is unnecessary. 3 - The t/ tests help you make sure things like your regexs work as I believe you had some weirdness with around net|com which would not have done what you wanted. Add the t/rcvd_parser.t lines FIRST (I usually put '' as the result portion of the code) and then write the code to parse them. In any case, I've done my best to implement the end goal I think you need and if you can please test the changes in trunk, that would be appreciated. svn commit -m 'changes to received parsing for gmx - bug 6877' Sending lib/Mail/SpamAssassin/Message/Metadata/Received.pm Sending t/rcvd_parser.t Transmitting file data .. Committed revision 1428716. Regards, KAM -- You are receiving this mail because: You are the assignee for the bug.
