https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6891

            Bug ID: 6891
           Summary: failure in xt/60_perlcritic.t from AsyncLoop.pm
                    prototype
           Product: Spamassassin
           Version: 3.4 SVN branch
          Hardware: PC
                OS: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Regression Tests
          Assignee: [email protected]
          Reporter: [email protected]
    Classification: Unclassified

xt/60_perlcritic....................NOK 11#   Failed test 'Test::Perl::Critic
for "../blib/lib/Mail/SpamAssassin/AsyncLoop.pm"'
#   at /usr/local/lib/perl5/site_perl/5.8.6/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in
"../blib/lib/Mail/SpamAssassin/AsyncLoop.pm":
# Subroutine prototypes used at line 87, column 1.
#   Subroutines::ProhibitSubroutinePrototypes (Severity: 5)
#     Contrary to common belief, subroutine prototypes do not enable
#     compile-time checks for proper arguments. Don't use them.

Removed the prototype on the sub domain_to_search_list and committing in a
second.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to