https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942
--- Comment #18 from Henrik Krohns <[email protected]> --- (In reply to Mark Martinec from comment #16) > Two potential issues: > > - the multi_tok_count_change (called by learn) does not atomically > increment token's spam and ham counts. If multiple auto-learning > child processes were to learn same tokens, we could lose some increments. > Should be worry or not to bother? > Perhaps using GETSET with a callback could be used to detect > (and later fix) possible collisions. If we can use 2.6 lua scripting to replace pack/unpack, it's the only sensible solution? Otherwise, nothing to worry. It's like winning in lottery. > - as already noted in comments by Henrik, dumping a database > (sa-learn --backup) uses a KEYS redis command, which prevents > other clients from accessing a database while it is running. > Moreover, the way keys() method is implemented in the Redis > cpan module, it returns all results in memory. This can make > creating a dump(backup) or a large database impossible or > just disruptive to other SA processes. > Should be worry or not to bother? Other solution, provide script for cli-utility which can do this efficiently. If not redis-cli, then something else. It's also possible to parse and convert a redis dumpfile (backup) - maybe most efficient. -- You are receiving this mail because: You are the assignee for the bug.
