https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6972

--- Comment #7 from Mark Martinec <[email protected]> ---
> I was going to deploy the chnages before this today - now I'm in a dilemma.
> Have these changes been running for a while on your systems?

Yes, running on our production mailer since middle of August (about
three weeks now), with some final refinements and benchmarking during
the test period. It survives redis server restarts and outages (logs
warnings during on outage, but reconnects and reloads Lua programs
when a server reappears).

Tried also the backup/restore (and noticed we need to add some
randomness to expiration times on a '--restore' operation to avoid
mass expiration of tokens in the same moment, now fixed).

The exact same redis client code is also used in my amavisd for its
pen pals and IP reputation databases. Currently released as 2.8.2-rc1
( http://amavis.org/release-notes.txt ).


Henrik writes:
> Just one though here.. would it be easy to create a generic Redis-connection
> module for SA? Think something like AskDNS. There were ideas around that
> Redis could be used for some hashing services etc..

I thought of it. The 'TinyRedis' package could be made into its own file,
or moved to Util.pm. Eventually it would be nice to make it a CPAN module
to avoid code duplication between SpamAssassin and amavisd, although this
would shed one of its benefits: self-contained code with no dependency
on new modules. The code is fairly small so code duplication is not a
big deal for now.

So yes, if other parts of SpamAssassin develop a need for the TinyRedis
package, we'll just move it out of the BayesStore/Redis.pm to its own.
It is not specific to a bayes function. AWL comes to mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to