On Thu, 27 Feb 2014, Kevin A. McGrail wrote:
On 2/27/2014 12:09 PM, John Hardin wrote:
> At best, I think this is added in Message.pm with my $text =
> $self->get_header ('subject') || "\n";
>
> Perhaps we need to add a tflag to not add subject for body rules to
> ignore this step.
That would pretty much require two $texts, wouldn't it? body rules without
that tflag would expect to run against the header as well...
To "properly" implement that tflag, in addition to not doing the
concatenation wouldn't all body rules not having the tflag also have to be
explicitly run against the Subject header so they maintain the current
semantics?
The current implementation would remain as-is. the tflag would ne a negation
such as tflag <rulename> do_not_add_subject which would only affect body type
rules. No need for add_subject as that's existing behavior.
Still, wouldn't you need a non-Subject version of $text to run those
tflagged body rules against, and changes to the rule processing to look at
the rule's tflags to decide which $text to run the rule's RE against?
(Note: I've been away from the details for a while, I'm assuming $text is
*not* built per-rule... if it is I'll stop objecting.)
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
[email protected] FALaholic #11174 pgpk -a [email protected]
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
...much of our country's counterterrorism security spending is not
designed to protect us from the terrorists, but instead to protect
our public officials from criticism when another attack occurs.
-- Bruce Schneier
-----------------------------------------------------------------------
14 days until Albert Einstein's 135th Birthday
