https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6994
--- Comment #10 from Kevin A. McGrail <[email protected]> --- (In reply to linda w from comment #9) > patch in directory 't': > > --- SATest.pm 2014-02-07 00:36:38.000000000 -0800 > +++ SATest.pm 2014-03-29 17:09:56.202426335 -0700 > @@ -167,6 +167,7 @@ > > mkdir ("log", 0755); > chmod (0755, "log"); # set in case log already exists with wrong > permissions > + system("chacl -B log || setfacl -b log"); # remove acls that confuse test > > rmtree ("log/user_state"); > rmtree ("log/outputdir.tmp"); Needs more logic to handle systems that do not have these commands otherwise you get screenfulls of this type of output: t/spamd_user_rules_leak...........sh: chacl: command not found sh: setfacl: command not found t/spamd_user_rules_leak...........ok Something like this pseudo code where you need to identify the best way to confirm chacl and setfacl are ready to go. Thoughts?: Index: t/SATest.pm =================================================================== --- t/SATest.pm (revision 1582317) +++ t/SATest.pm (working copy) @@ -19,6 +19,8 @@ $SKIP_SETUID_NOBODY_TESTS $SKIP_DNSBL_TESTS $have_inet4 $have_inet6 $spamdhost $spamdport); +use constant HAS_ACL => eval { #TEST FOR chacl or setfacl }; + BEGIN { require Exporter; use vars qw(@ISA @EXPORT @EXPORT_OK); @@ -168,6 +170,9 @@ mkdir ("log", 0755); chmod (0755, "log"); # set in case log already exists with wrong permissions + if (HAS_ACL) { + system("chacl -B log || setfacl -b log"); # remove acls that confuse test + } rmtree ("log/user_state"); rmtree ("log/outputdir.tmp"); -- You are receiving this mail because: You are the assignee for the bug.
