On 5/22/2014 7:48 PM, Karsten Bräckelmann wrote:
On Thu, 2014-05-22 at 18:34 -0500, David B Funk wrote:
After doing some experimenting with that code I came up with something that
I'd argue is more semantically correct:
# if we've got a long series of blank lines, limit them
if (defined $start) {
my $max_blank_lines = 20;
my $num = $start-$cnt;
if ($num > $max_blank_lines) {
splice @message, $cnt+2, $num-$max_blank_lines;
}
undef $start;
}
IE limit a message to no more than "$max_blank_lines" in a row, not the total
collapse of more than 11. (adjust $max_blank_lines as you see fit or make it
a configurable parameter).
+1
Can you file a bug report or raise the topic in dev@ list? The code
change is sufficiently simple, but I want that issue discussed first.
Wonder what's the reason for that collapsing in the first place.
Forwarding this idea to the dev list for discussion.
jm wrote the original version of this code for this bug:
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=3712
I see no issue with the change, given as this code is intended to trim
down thousands of newlines. I haven't tested it yet, though.
I am already seeing spammers adapt to this idea, and they are padding
the empty lines with single '/' and '\' characters.
