https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7065
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Kevin A. McGrail <[email protected]> --- (In reply to Mark Martinec from comment #5) > Bug 7065: Debug Mode breaks Bayes but only if DBM storage is used > Sending BayesStore/DBM.pm > Committed revision 1608413. > > Took the liberty to also change a couple of other dbg() calls > in that module into a sprintf form. I know that JM preferred > to have debug strings containing interpolated variables, instead > of having them decoupled through formatting. It's hard to argue > personal preferences regarding which is easier to read, > but I also claim one technical advantage: passing additional > arguments in a subroutine call is cheap as it only involves > aliasing, not copying. On the other hand, constructing a > complete debug string by a caller, only to be later discarded > by a logging routine (unless debugging is enabled) sounds > like a waste. Sounds good to me and a good find on why it breaks that form of Bayes. This can be marked resolved/fixed, yes? -- You are receiving this mail because: You are the assignee for the bug.
