https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7070

--- Comment #11 from Quanah Gibson-Mount <qua...@zimbra.com> ---
(In reply to Kevin A. McGrail from comment #10)


> I believe rbl_timeout's t_min will only apply to asyncLookup if a zone is
> specified.
> 
> Do you see "async: applying by_zone settings for" in the debug output?

a) by_zone does not appear in debug output

/opt/zimbra/zimbramon/bin/spamassassin -D all < /tmp/spam.x > /tmp/q.x 2>&1

[zimbra@zre-ldap003 SpamAssassin]$ grep by_zone /tmp/q.x
[zimbra@zre-ldap003 SpamAssassin]$



b) the code clearly sets min timeout from config, regardless of whether or not
a zone is supplied

I added the following to AsyncLoop.pm:

  dbg("async: ent timeout: ".$ent->{timeout_min});
  dbg("async: config timeout: ".$settings->{rbl_timeout_min});
  my $t_end = $ent->{timeout_min};       # application-specified has precedence
  dbg("async: t_end1: ".$t_end);
  $t_end = $settings->{rbl_timeout_min}  if $settings && !defined $t_end;
  dbg("async: t_end2: ".$t_end);
  $t_end = 0.2 * $t_init  if !defined $t_end;
  dbg("async: t_end3: ".$t_end);
  $t_end = 0  if $t_end < 0;  # just in case
  dbg("async: t_end4: ".$t_end);
  $t_init = $t_end  if $t_init < $t_end;


After doing this, we find:

Jul 15 18:02:56.445 [22388] dbg: config: rbl_timeout:90
Jul 15 18:02:56.445 [22388] dbg: config: rbl_timeout_min:60

Jul 15 18:02:57.119 [22388] dbg: plugin:
Mail::SpamAssassin::Plugin::URIDNSBL=HASH(0x27b5470) implements
'parsed_metadata', priority 0
Jul 15 18:02:57.124 [22388] dbg: check: tagrun - tag URIHOSTS is now ready,
value: askpcm.com
Jul 15 18:02:57.125 [22388] dbg: check: tagrun - tag URIDOMAINS is now ready,
value: askpcm.com
Jul 15 18:02:57.125 [22388] dbg: uridnsbl: considering host=askpcm.com,
domain=askpcm.com
Jul 15 18:02:57.125 [22388] dbg: async: launching A/askpcm.com.multi.surbl.org
for DNSBL:askpcm.com:multi.surbl.org
Jul 15 18:02:57.127 [22388] dbg: dns: bgsend, DNS servers: [127.0.0.1]:53,
[10.137.27.3]:53, [10.210.0.166]:53
Jul 15 18:02:57.127 [22388] dbg: dns: attempt 1/3, trying connect/sendto to
[127.0.0.1]:53
Jul 15 18:02:57.127 [22388] dbg: dns: connect_sock, resolver: yes
Jul 15 18:02:57.127 [22388] dbg: dns: LocalAddr: 0.0.0.0, name server(s):
[127.0.0.1]:53, [10.137.27.3]:53, [10.210.0.166]:53
Jul 15 18:02:57.132 [22388] dbg: dns: 53959 configured local ports for DNS
queries
Jul 15 18:02:57.133 [22388] dbg: dns: resolver socket rx buffer size is 124928
bytes, local port 52701
Jul 15 18:02:57.133 [22388] dbg: dns: providing a callback for id:
16746/IN/A/askpcm.com.multi.surbl.org
Jul 15 18:02:57.133 [22388] warn: Use of uninitialized value in concatenation
(.) or string at /opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line
213.
Jul 15 18:02:57.133 [22388] dbg: async: ent timeout:
Jul 15 18:02:57.134 [22388] warn: Use of uninitialized value in concatenation
(.) or string at /opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line
214.
Jul 15 18:02:57.134 [22388] dbg: async: config timeout:
Jul 15 18:02:57.134 [22388] warn: Use of uninitialized value $t_end in
concatenation (.) or string at
/opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line 216.
Jul 15 18:02:57.134 [22388] dbg: async: t_end1:
Jul 15 18:02:57.134 [22388] warn: Use of uninitialized value $t_end in
concatenation (.) or string at
/opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line 218.
Jul 15 18:02:57.134 [22388] dbg: async: t_end2:
Jul 15 18:02:57.134 [22388] dbg: async: t_end3: 18
Jul 15 18:02:57.134 [22388] dbg: async: t_end4: 18
Jul 15 18:02:57.134 [22388] dbg: async: starting: URIBL_PH_SURBL, URI-DNSBL,
DNSBL:askpcm.com:multi.surbl.org (timeout 90.0s, min 18.0s)
Jul 15 18:02:57.134 [22388] dbg: dns: URIBL_PH_SURBL lookup start
Jul 15 18:02:57.134 [22388] dbg: async: launching A/askpcm.com.multi.uribl.com
for DNSBL:askpcm.com:multi.uribl.com
Jul 15 18:02:57.134 [22388] dbg: dns: bgsend, DNS servers: [127.0.0.1]:53,
[10.137.27.3]:53, [10.210.0.166]:53
Jul 15 18:02:57.134 [22388] dbg: dns: attempt 1/3, trying connect/sendto to
[127.0.0.1]:53
Jul 15 18:02:57.135 [22388] dbg: dns: providing a callback for id:
17826/IN/A/askpcm.com.multi.uribl.com
Jul 15 18:02:57.135 [22388] warn: Use of uninitialized value in concatenation
(.) or string at /opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line
213.
Jul 15 18:02:57.135 [22388] dbg: async: ent timeout:
Jul 15 18:02:57.135 [22388] warn: Use of uninitialized value in concatenation
(.) or string at /opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line
214.
Jul 15 18:02:57.135 [22388] dbg: async: config timeout:
Jul 15 18:02:57.135 [22388] warn: Use of uninitialized value $t_end in
concatenation (.) or string at
/opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line 216.
Jul 15 18:02:57.135 [22388] dbg: async: t_end1:
Jul 15 18:02:57.135 [22388] warn: Use of uninitialized value $t_end in
concatenation (.) or string at
/opt/zimbra/zimbramon/lib/Mail/SpamAssassin/AsyncLoop.pm line 218.
Jul 15 18:02:57.135 [22388] dbg: async: t_end2:
Jul 15 18:02:57.135 [22388] dbg: async: t_end3: 18
Jul 15 18:02:57.135 [22388] dbg: async: t_end4: 18
Jul 15 18:02:57.135 [22388] dbg: async: starting: URIBL_BLACK, URI-DNSBL,
DNSBL:askpcm.com:multi.uribl.com (timeout 90.0s, min 18.0s)
Jul 15 18:02:57.136 [22388] dbg: dns: URIBL_BLACK lookup start
Jul 15 18:02:57.136 [22388] dbg: async: query
17826/IN/A/askpcm.com.multi.uribl.com already underway, adding no.2 URIBL_RED
Jul 15 18:02:57.136 [22388] dbg: dns: URIBL_RED lookup start
Jul 15 18:02:57.136 [22388] dbg: async: launching
A/askpcm.com.dob.sibl.support-intelligence.net for
DNSBL:askpcm.com:dob.sibl.support-intelligence.net
Jul 15 18:02:57.136 [22388] dbg: dns: bgsend, DNS servers: [127.0.0.1]:53,
[10.137.27.3]:53, [10.210.0.166]:53
Jul 15 18:02:57.136 [22388] dbg: dns: attempt 1/3, trying connect/sendto to
[127.0.0.1]:53
Jul 15 18:02:57.136 [22388] dbg: dns: providing a callback for id:
23075/IN/A/askpcm.com.dob.sibl.support-intelligence.net


Clearly, the min value is not properly passed in

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to