https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7224
Bug ID: 7224
Summary: Multiple issues with SPF Plugin
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: [email protected]
Reporter: [email protected]
Created attachment 5315
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5315&action=edit
patch for SPF plugin
Benny,
incorrect header parsing is also described in bug #6920 which seems old and
inaccurate. You may want to invalidate that and fix this.
First, the line:
my @internal_hdrs = split("\n", $scanner->get('ALL-INTERNAL'));
does not do what it means. Perhaps the PerMessageStatus::get() function
returns different values depending on some other software? I saved the string
it returns to a file, and it compared equal to the output of:
sed -n '1,20s/$/\n/p' < mailmessage
That is, doubled newlines and no unfolding (line 20 is the first Received:).
Thus, splitting at newlines makes no sense. I attach a patch to unfold header
fields correctly. (NOTE: although the patch is taken against old stuff, the
trunk doesn't seem to differ --see sub get_all_hdrs_in_rcvd_index_range at line
2897.)
Second, a single Authentication-Results field can contain multiple SPF results.
The plugin gets the first one only. I just mention this in view of the third
issue, since HELO is seldom used.
Third, it may be useless to check HELO results when an MFROM result was already
found in an internal Received-SPF or Authentication-Results field. It would be
handy to have a configuration item to avoid a DNS lookup in such cases.
Ale
--
You are receiving this mail because:
You are the assignee for the bug.
