https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7231

--- Comment #4 from Mark Martinec <[email protected]> ---
Created attachment 5321
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5321&action=edit
Suggested patch for trunk: compatibility with Net::DNS

Checking the documentation of Net::DNS it turns out that a method
rdatastr() on a resource record object (Net::DNS::RR) is undocumented,
but there is an equivalent and documented method rdstring().

The rdstring() appeared in version Net::DNS 0.69. Currently at
Net::DNS 1.01 the rdatastr() still exists and calls rdstring,
but considering that it is undocumented it would be better to
avoid using the old method - one can never be sure when it will
disappear.

Another point is a method address(), which is applicable to
objects of type Net::DNS::RR::A and Net::DNS::RR::AAAA,
and returns an IP address in textual form. As it happens
it is much like the more generic rdstring(), but that might
change in future. The address() method appeared in version
Net::DNS 0.69.

The attached patch makes use of the new methods, but falls back
to pre-0.69 if necessary. I'd like to fold it into trunk.

Alternatively, if we decide that the minimal necessary version
of Net::DNS is 0.69 (December 2012), then all these compatibility
fallbacks can be avoided, greatly simplifying the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to