Just to clarify. Do you propose an additional `-f` command line option for Windows? You specify `-f somefile` and spamassassin and friends read DEF_RULES_DIR, LOCAL_RULES_DIR, LOCAL_STATE_DIR from the file?
Von: Kevin A. McGrail [mailto:[email protected]] Gesendet: Donnerstag, 22. Oktober 2015 03:30 An: Martin Puppe <[email protected]>; [email protected] Betreff: Re: Build-time vs run-time configuration of paths My opinion is to add the support for Windows so I don't foresee a gigantic hurdle. Bang out whichever way works best for you because I don't want to stand in the way of progress. But yes, a -f and an is running windows logic check that then reads a site config file sounds sane and unlikely to impact things too badly. I don't see the need for a config option but if it's needed I would support that too. Regards, KAM On October 21, 2015 1:48:31 AM PDT, Martin Puppe <[email protected]<mailto:[email protected]>> wrote: Here is where I am coming from. I am trying to minimize the number of custom patches we have to apply before building SpamAssassin for Windows. That benefits us because we do not have to merge when SpamAssassin gets updates. And it benefits anyone else who is trying to run SpamAssassin on Windows. That said, on Windows systems, preparing a Perl application for distribution is unfortunately not as straight-forward as on Unix systems. While the filesystem layout is standardized for Unix systems (at least for all systems running a given distribution), it is not at all for Windows systems. So, a distributor on a Unix system can simply set some of the variables described in PACKAGING when he or she runs `perl Makefile.PL`. Unfortunately, that does not work on Windows. Currently, we are patching the various SpamAssassin scripts (sa-update, spamassassin, spamd, etc.) so that they all read a `./path.config` file at runtime. That is obviously! not very Unix-y. So, it might not be a great idea to merge this into upstream, even behind `am_running_on_windows()`. (Or is it?) I do not have any specific proposal at the moment. (A `--siteconfigpath` option for sa-udpate would probably go a long way though). I am just trying to raise awareness and solicit some opinions on the matter. Regards, Martin Puppe ________________________________ ________________________________ JAM Software GmbH Managing Director: Joachim Marder Am Wissenschaftspark 26 * 54296 Trier * Germany Phone: +49 (0)651-145 653 -0 * Fax: +49 (0)651-145 653 -29 Commercial register number HRB 4920 (AG Wittlich) http://www.jam-software.com ________________________________ ________________________________ JAM Software GmbH Geschäftsführer: Joachim Marder Am Wissenschaftspark 26 * 54296 Trier * Germany Tel: 0651-145 653 -0 * Fax: 0651-145 653 -29 Handelsregister Nr. HRB 4920 (AG Wi! ttlich) http://www.jam-software.de
