https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7497

Merijn van den Kroonenberg <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Merijn van den Kroonenberg <[email protected]> ---

The actual code causing the problem:

./masses/rule-update-score-gen/generate-new-scores.sh:202:grep -v ^score
rules/72_active.cf > rules/72_active.cf-scoreless
./masses/rule-update-score-gen/generate-new-scores.sh:203:mv -f
rules/72_active.cf-scoreless rules/72_active.cf

basically all score lines are stripped from 72_active.cf

Additionally I am wondering if those grep statements might be removed
altogether, because right now they are not doing a thing, as all score
statements in the 72_active.cf are commented out. I think this is done by the
build/mkrules program.

build/mkrules line 455:
      # comment "score" lines for sandbox rules (bug 5558)
      # use generated scores, though, if the rule is active
      if ($type eq 'score' && $issandbox &&
        !($isscores && $active_rules->{$name}))
      {
        $orig =~ s/^/#/g;
      }

But I don’t understand above code enough to be sure.

To test or experiment with grep and special characters:

wget http://sa-update.ena.com/1813258.tar.gz
extract the 72_active.cf
Then experiment with locale settings(eg. SET LANG=en_US)
and run:
grep -v ^score 72_active.cf > test.cf
And test.cf should not end with the line: 
Binary file 72_active.cf matches

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to