https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7443
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.4.2 |3.4.3 --- Comment #7 from Kevin A. McGrail <[email protected]> --- Pushing to 3.4.3. KB's comments, off bz agree with mine: These would be my current objections: - The (background)?-?color change is not correct, obvious intention was to make the hyphen optional, so /(bg-?)?c/ nested. If leaving out the hyphen is abuseable at all and some renderers do accept it. - The "protecting from word values" should be a non-issue. The immediately following regex test for $value does the same. - The code with the "# repetitive from above -- need to collapse logic" comment is self-explaining, why my comment was "needs polish". No argument what it does and why it is necessary in the report, either. - The code change of setting $new right after the comment that it's getting set below is icky. If correct at all, it misses to adjust the comments. In other words, still needs polish. Or an explanation... -- You are receiving this mail because: You are the assignee for the bug.
