https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7616

Bill Cole <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Test fail due to change in  |REVIEW: Test fail due to
                   |Util.pm sub wrap            |change in Util.pm sub wrap

--- Comment #4 from Bill Cole <[email protected]> ---
THIS PATCH NEEDS REVIEW AND VOTES!

Last week, we fixed a slightly imperfect header-folding flaw (due to treating
tabs as single characters) by implementing a configurable header-folding width
and counting tabs as 8 characters. Because the first implementation of
"counting tabs as 8 characters" used a Perl 5.14 feature, that was turning into
"convert tabs to 8 spaces," and imperfect solution that would have been fine,
since the only tabs this code sees are at the start of lines.

That change broke (as revealed by t/util_wrap.t) due to a quirk of nested
operations which caused a length() call to always see a null string instead of
a substituted string. This patch re-implements the functionality of the "r"
modifier to the s/// regex substitution operation by copying the string to a
scratch variable which is substituted and then measured, leaving the original
fully intact.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to